[i3run] multi criteria not working #101

New issue

Closed

opened 2021-08-12 13:26:03 +00:00 by budRich · 0 comments

budRich commented

2021-08-12 13:26:03 +00:00

(Migrated from github.com)

The reason this isn't working is because of the --rename option, which works like this:
--rename ORIGINAL --class NEW (or --instance NEW)...
So it renames the ORIGINAL with NEW, and see which one is set to determine.
This wouldn't be reliable if we would pass --rename ORIGINAL --class NEW --instance INSTANCE ..

The best solution would be to replace --rename with --rename-class ORIGINAL, and --replace-instance ORIGINAL.
that would also allow for multiple renames in one command.

Problem is that I (and maybe others) rely on current behavior, so i think i will keep the old, but mark it depracated and print a warning msg to stderr whenever it is used, and remove it in the future.

The reason this isn't working is because of the `--rename` option, which works like this: --rename ORIGINAL --class NEW (or --instance NEW)... So it renames the ORIGINAL with NEW, and see which one is set to determine. This wouldn't be reliable if we would pass --rename ORIGINAL --class NEW --instance INSTANCE .. The best solution would be to replace --rename with --rename-class ORIGINAL, and --replace-instance ORIGINAL. that would also allow for *multiple renames* in one command. Problem is that I (and maybe others) rely on current behavior, so i think i will keep the old, but mark it depracated and print a warning msg to stderr whenever it is used, and remove it in the future.